-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding static analysis with PVS-Studio #2061
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2061 +/- ##
==========================================
- Coverage 62.04% 61.82% -0.22%
==========================================
Files 96 96
Lines 19194 19098 -96
Branches 9833 9817 -16
==========================================
- Hits 11909 11808 -101
- Misses 4978 4995 +17
+ Partials 2307 2295 -12
Continue to review full report at Codecov.
|
Also not for this MR, but maybe with the above to-do: is there anyway we can display the results somewhere without having to download the artifact? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I did this change because I saw the following warning on the Github Actions page: "Retention days is greater than the max value allowed by the repository setting, reduce retention to 7 days"
I have added a new issue describing some of the improvements we could do regarding PVS-Studio: #2074. Hopefully somebody will tackle those things at some point 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
In the middle of 2021 I got a free license for PVS-Studio so that we can use it to detect defects in the codebase:
https://pvs-studio.com/en/order/open-source-license/
In this PR I will try to add the automatic execution of this static analyser into our CI pipeline.
Note that this is just storing the result of the static analysis as an artifact in the Github Actions page. Example:
https://github.com/Exiv2/exiv2/actions/runs/1757710199
However we are not blocking PRs in case of emerging new defects detected by the tool. I can try to investigate that in a following PR.